fix: solved bulk issuance and with email issuance flow #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KulkarniShashank
commented
Mar 4, 2024
KulkarniShashank
commented
- Solved bulk issuance when upload csv and issue the credentials
…suance Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
shitrerohit
approved these changes
Mar 4, 2024
ankita-p17
approved these changes
Mar 4, 2024
tipusinghaw
reviewed
Mar 4, 2024
| protocolVersion: protocolVersion || 'v1', | ||
| credentialFormats: { | ||
| indy: { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Any specific reason to disable eslint?
There was a problem hiding this comment.
We need to eliminate the isRequired attribute from the payload to avoid mapping unnecessary attributes as required. Therefore, we should create a separate variable for isRequired and ensure that it is not utilized within this function.
| } | ||
| return this.sendEmailForCredentialOffer(sendEmailCredentialOffer); | ||
| }); | ||
| emailPromises.push(Promise.all(batchPromises)); |
There was a problem hiding this comment.
I am not sure how it will handle the remaining batch if the 1st batch will fail.
There was a problem hiding this comment.
We will check the possibilities for validation and we will create separate PR for it.
Signed-off-by: rohit.shitre <[email protected]>
|
shitrerohit
approved these changes
Mar 5, 2024
shitrerohit
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.